Skip to content

TCA-499 eslint rules & fixes -> dev #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 49 commits into from
Nov 15, 2022
Merged

TCA-499 eslint rules & fixes -> dev #414

merged 49 commits into from
Nov 15, 2022

Conversation

brooketopcoder
Copy link
Contributor

https://topcoder.atlassian.net/browse/TCA-499

This PR:

  • replaces tslint w/eslint
  • adds some new eslint rules
  • fixes most of the lint issues in the learn tool
  • turns off the lint check in the build

vas3a and others added 30 commits July 14, 2022 15:58
TCA-561 Update eslint rules to match our project -> TCA-499_eslint
TCA-645 Auto-fix Lint Issues -> TCA-499_eslint
…hat were introduced when we removed prettier. #time 3h
…unction component definitions to be function expressions #time 30
…how it worked and made the issue worse. Thanks Vasilica #time 15m
TCA-647 Remove prettier and tslint -> TCA-499_eslint
TCA-645 Example Complex Lint Fixes -> TCA-499_eslint
Copy link
Collaborator

@vas3a vas3a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@brooketopcoder brooketopcoder merged commit e2e67ee into dev Nov 15, 2022
@brooketopcoder brooketopcoder deleted the TCA-499_eslint branch November 15, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants